Code breaker

Hi Sophie, You've fallen for a classic one here - the if statements shouldn't have semi-colons after them. If they do, like they do here, then Java compiles them as "empty" statements - i.e. "if(condition) {}". The braces afterwards just denote a separate block of code. So what you actually have here since the if statements are discounted, is: ...hence overall nothing happens! If you remove the semi-colons from the end of the if statements, it should work as you expect. At some point, we should probably put warnings in to catch this sort of thing... If you're a teacher, you may also find the Greenroom useful (http://greenroom.greenfoot.org) - it's specifically geared at teachers making use of Greenfoot.

Thanks for this. It all works now. I don't feel however that I have fallen for anything other than copying directly from the codebreaker materials. Would it bepossiblefor someone to review the Codebtraker materials and correct the errors because it is impossible to enthuse students about an enviropnment that never seems to work because of errors in the materials. Regards Sophie

Hi Sophie, I'm assuming you mean the set of examples you can download from this page? I've taken a quick look through and in all the provided Ship.java files (3 as far as I can tell) I haven't seen that mistake made. Where exactly did you find the erroneous code in the materials?